fix i18n keys word for word deletion #576
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@catreedle, it's currently looking like this :) Would we want to allow the menu label to be split to the next line? Might be a good idea in case other languages are longer than English. 
|
hi @andrewtavis I tried fixing this and had to increase the row height in general. Hope it's okay. |
|
The change for the radio button looks really good, @catreedle, but would we be able to reduce the spacing if there's a sub menu? See below: 
I think it'd be great if we could reduce the above distance by half 🤔 |
I will look into it 😊 |
|
Also @catreedle, note that the most recent merged PR updated Scribe-i18n on main :) Just so you're aware that there have been edits. The change was for the About menu option that leads to the website. The Scribe key icon was too short, so I decided to switch it to a globe and the text to "Visit the Scribe website", which has since been updated in Scribe-i18n 🌐 |
noted. thank you! :) |
|
Merged in main so getting this in will be easier, @catreedle :) |
|
Layout update: |
andrewtavis
left a comment
andrewtavis
left a comment
There was a problem hiding this comment.
praise: So great to have this finalized and to also have the fix for the line height, @catreedle! Thanks for your hard work and the care that you put into the styling here 🎨
note: I sent an incorrect commit to your Scribe-i18n PR that was just merged, but realized it here and sent a fix along. Didn't realize that there's no space added at the end of the xcstrings file. Let's keep this in mind as we work, and maybe we need to remove xcstrings_file.write("\n") at the end of convert_jsons_to_xcstrings.py. Let me know what your thoughts are on that :)
2 participants
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
Fix i18n keys word for word deletion and description in Scribe/SettingsTab/SettingsTableData.swift
Related issue